Changeset 774

Timestamp:

Feb 3, 2011, 2:50:45 AM (14 years ago)

Author:

gav

Message:

Use transactional service for TaskProcedure update to prevent maintenanceActions leaking into database when procedureStepNumber fails validation.

Location:

branches/features/taskProcedureRework/grails-app

Files:

• controllers/TaskProcedureDetailedController.groovy (modified) (2 diffs)
• services/TaskProcedureService.groovy (added)

branches/features/taskProcedureRework/grails-app/controllers/TaskProcedureDetailedController.groovy

@@ -6 +6 @@
     def filterService
     def authService
+    def taskProcedureService
 
     def index = { redirect(action:list,params:params) }
@@ -99 +100 @@
 
     def update = {
-        def taskProcedureInstance = TaskProcedure.get( params.id )
-        if(taskProcedureInstance) {
-            if(params.version) {
-                def version = params.version.toLong()
-                if(taskProcedureInstance.version > version) {
+        def result = taskProcedureService.update(params)
 
-                    taskProcedureInstance.errors.rejectValue("version", "default.optimistic.locking.failure")
-                    render(view:'edit',model:[taskProcedureInstance:taskProcedureInstance])
-                    return
-                }
-            }
-            taskProcedureInstance.properties = params
-            taskProcedureInstance.lastUpdatedBy = authService.currentUser
-            taskProcedureInstance.lastUpdated = new Date() // Required to trigger version increment.
+        if(!result.error) {
+            flash.message = g.message(code: "default.update.success", args: ["TaskProcedure", params.id])
+            redirect(controller:'taskDetailed',
+                            action:'show',
+                            id:result.taskProcedureInstance.linkedTask.id,
+                            params:[showTab:"showProcedureTab"])
+            return
+        }
 
-            // Gaps in the html index's can be created by adding 2 items and removing the first one.
-            // This creates a gap at the missing index where LazyList will return a null.
-            def nullMaintenanceActions = taskProcedureInstance.maintenanceActions.findAll {!it}
-            if (nullMaintenanceActions) {
-                taskProcedureInstance.maintenanceActions.removeAll(nullMaintenanceActions)
-            }
+        if(result.error.code == "default.not.found") {
+            flash.message = g.message(code: result.error.code, args: result.error.args)
+            redirect(action:list)
+            return
+        }
 
-            // Save for restoration if validation fails.
-            def savedMaintenanceActions = new ArrayList(taskProcedureInstance.maintenanceActions)
-
-            // Remove toBeDeleted before validation.
-            def toBeDeleted = taskProcedureInstance.maintenanceActions.findAll {it.toBeDeleted}
-            if (toBeDeleted) {
-                taskProcedureInstance.maintenanceActions.removeAll(toBeDeleted)
-            }
-
-            if(!taskProcedureInstance.hasErrors() && taskProcedureInstance.save(flush: true)) {
-                flash.message = "TaskProcedure ${params.id} updated"
-                redirect(controller:'taskDetailed',
-                                action:'show',
-                                id:taskProcedureInstance.linkedTask.id,
-                                params:[showTab:"showProcedureTab"])
-            }
-            else {
-                // Restore the saved items, some of which contain toBeDeleted flags but
-                // have not been deleted yet since validation failed.
-                // The toBeDeleted items are hidden in the view.
-                taskProcedureInstance.maintenanceActions = savedMaintenanceActions
-                // Populate maintenanceAction errors for display.
-                taskProcedureInstance.maintenanceActions.each { it.validate() }
-                render(view:'edit',model:[taskProcedureInstance:taskProcedureInstance])
-            }
-        }
-        else {
-            flash.message = "TaskProcedure not found with id ${params.id}"
-            redirect(action:list)
-        }
+        render(view:'edit', model:[taskProcedureInstance: result.taskProcedureInstance])
     }