Changeset 295

Timestamp:

Jan 25, 2010, 10:57:30 AM (15 years ago)

Author:

gav

Message:

Authority add/remove logic in r294 not behaving as expected, fixed.
Switch views back to using Authority desctiptions.

Location:

trunk/grails-app

Files:

• controllers/PersonController.groovy (modified) (6 diffs)
• views/person/create.gsp (modified) (1 diff)
• views/person/edit.gsp (modified) (1 diff)
• views/person/show.gsp (modified) (1 diff)

trunk/grails-app/controllers/PersonController.groovy

@@ -42 +42 @@
             return
         }
-        List roleNames = []
-        for (role in person.authorities) {
-            roleNames << role.authority
-        }
-        roleNames.sort { n1, n2 ->
-            n1 <=> n2
-        }
-        [person: person, roleNames: roleNames]
+        def authorityList = person.authorities.sort { p1, p2 -> p1.id <=> p2.id }
+        [person: person, authorityList: authorityList]
     }
 
@@ -138 +132 @@
 
             if (!person.hasErrors() && person.save(flush: true)) {
-                addRemoveRoles(person)
+                addRemoveAuthorities(person)
                 flash.message = "Person '$params.id - $params.loginName' updated."
                 redirect action: show, id: person.id
@@ -165 +159 @@
             person.setPersonGroupsFromCheckBoxList(params.personGroups)
             if (person.save(flush: true)) {
-                addRemoveRoles(person)
+                addRemoveAuthorities(person)
                 redirect action: show, id: person.id
             }
@@ -175 +169 @@
     }
 
-    private void addRemoveRoles(person) {
+    /**
+    * Add or remove authorities from person as indicated in params.
+    */
+    private void addRemoveAuthorities(person) {
+        def authMap = [:]
+
+        // Build authMap from params.
         for (key in params.keySet()) {
-            if(key.startsWith("ROLE"))
-                Authority.findByAuthority(key).addToPersons(person)
-            else if(key.startsWith("_ROLE"))
-                Authority.findByAuthority(key.substring(1)).removeFromPersons(person)
+            if(key.startsWith("ROLE")) {
+                authMap.(key.toString()) = "add"
+            }
+            else if(key.startsWith("_ROLE")) {
+                if( !authMap.(key.substring(1)) ) authMap.(key.substring(1)) = "remove"
+            }
+        }
+
+        // Add or remove authorities.
+        for(a in authMap) {
+            if(a.value == "add")
+                Authority.findByAuthority(a.key.toString()).addToPersons(person)
+            else
+                Authority.findByAuthority(a.key.toString()).removeFromPersons(person)
         }
     }
@@ -187 +197 @@
 
         List roles = getLimitedAuthorityList()
-        roles.sort { r1, r2 ->
-            r1.authority <=> r2.authority
-        }
         Set userRoleNames = []
         for (role in person.authorities) {
@@ -205 +212 @@
     * Get the full authorityList if current user is an App Admin else leave that authority off the list.
     */
-    def getLimitedAuthorityList = {
+    private List getLimitedAuthorityList() {
         def authorityList = []
         if(authenticateService.ifAnyGranted('ROLE_AppAdmin'))
-            authorityList = Authority.list().sort { p1, p2 -> p1.authority.compareToIgnoreCase(p2.authority) }
+            authorityList = Authority.list().sort { p1, p2 -> p1.id <=> p2.id }
         else
-            authorityList = Authority.withCriteria { gt("id", 1L) }.sort { p1, p2 -> p1.authority.compareToIgnoreCase(p2.authority) }
+            authorityList = Authority.withCriteria { gt("id", 1L) }.sort { p1, p2 -> p1.id <=> p2.id }
 
         return authorityList
     }
-}
+} // end class

trunk/grails-app/views/person/create.gsp

@@ -130 +130 @@
                     <g:each in="${authorityList}">
                     <tr>
-                        <td valign="top" class="name" align="left">${it.authority.encodeAsHTML()}</td>
+                        <td valign="top" class="name" align="left">${it.description.encodeAsHTML()}</td>
                         <td align="left">
                             <g:checkBox name="${it.authority}" value="${it.authority == 'ROLE_AppUser'}"/>

trunk/grails-app/views/person/edit.gsp

@@ -137 +137 @@
                     <g:each var="entry" in="${roleMap}">
                     <tr>
-                        <td valign="top" class="name" align="left">${entry.key.authority.encodeAsHTML()}</td>
+                        <td valign="top" class="name" align="left">${entry.key.description.encodeAsHTML()}</td>
                         <td align="left"><g:checkBox name="${entry.key.authority}" value="${entry.value}"/></td>
                     </tr>

trunk/grails-app/views/person/show.gsp

@@ -84 +84 @@
                     <td valign="top" class="value">
                         <ul>
-                        <g:each in="${roleNames}" var='name'>
-                            <li>${name}</li>
+                        <g:each  var='a' in="${authorityList}">
+                            <li>${a.description.encodeAsHTML()}</li>
                         </g:each>
                         </ul>