Changeset 203 for trunk/grails-app/services

Timestamp:

Nov 30, 2009, 10:28:58 PM (14 years ago)

Author:

gav

Message:

Move task recurring schedule creation to a service.

Location:

trunk/grails-app/services

Files:

• TaskRecurringScheduleService.groovy (modified) (4 diffs)
• TaskService.groovy (modified) (4 diffs)

trunk/grails-app/services/TaskRecurringScheduleService.groovy

@@ -6 +6 @@
     def taskService
 
+    /**
+    * Generate all enabled recurring tasks.
+    */
     def generateAll() {
 
-        /// @todo: disable recurringSchedule when moving a task to trash.
         def taskRecurringScheduleList = TaskRecurringSchedule.findAllByEnabled(true)
 
@@ -17 +19 @@
                     p.targetStartDate = it.nextTargetStartDate
                     p.targetCompletionDate = it.nextTargetCompletionDate
+                    if(it.task.taskProcedure) p.taskProcedure = it.task.taskProcedure
                     def result = taskService.createSubTask(it.task, p)
                     if( !result.error ) {
@@ -26 +29 @@
                     }
                     else {
-                        log.error result
+                        log.error "Sub task generation for recurring schedule ${it.id} failed."
+                        log.error result.taskInstance.errors
                     }
             }
@@ -33 +37 @@
     }
 
+    /**
+    * Creates a new recurring schedule for a task with the given params.
+    * @param params The params to use when creating the new recurring schedule.
+    * @returns A map containing result.error=true (if any error) and result.taskRecurringScheduleInstance and result.taskId.
+    */
+    def create(params) {
+        TaskRecurringSchedule.withTransaction { status ->
+            def result = [:]
+
+            def fail = { Object[] args ->
+                status.setRollbackOnly()
+                if(args.size() == 2) result.taskRecurringScheduleInstance.errors.rejectValue(args[0], args[1])
+                result.error = true
+                return result
+            }
+
+            result.taskRecurringScheduleInstance = new TaskRecurringSchedule(params)
+            result.taskId = result.taskRecurringScheduleInstance.task.id
+
+            if(!result.taskRecurringScheduleInstance.validate())
+                return fail()
+
+            def taskInstance = Task.lock(result.taskId)
+
+            if(!taskInstance)
+                return fail('task', "task.notFound")
+
+            if(taskInstance.taskRecurringSchedule)
+                return fail('task', "tast.taskRecurringSchedule.alreadyExists")
+
+            if(taskInstance.taskStatus.id == 3)
+                return fail('task', "task.operationNotPermittedOnCompleteTask")
+
+            if(taskInstance.trash)
+                return fail('task', "task.operationNotPermittedOnTaskInTrash")
+
+            if(result.taskRecurringScheduleInstance.nextTargetStartDate < dateUtilService.getToday())
+                return fail("nextTargetStartDate", "taskRecurring.nextTargetStartDate.NotInTheFuture")
+
+            taskInstance.taskRecurringSchedule = result.taskRecurringScheduleInstance
+
+            if(!result.taskRecurringScheduleInstance.save() || !taskInstance.save())
+                return fail()
+
+            // All went well if we get to here.
+            return result
+
+        } //end withTransaction
+    } // end create()
+
 } // end of class

trunk/grails-app/services/TaskService.groovy

@@ -11 +11 @@
 
     /**
-    * Determines and returns a possible parent list
+    * Determines and returns a possible parent list for a task.
     * @param taskInstance The task to use when determining the possible parent list.
     * @returns A list of the possible parents.
@@ -123 +123 @@
 
             if(result.entryInstance.validate()) {
-                def taskInstance = Task.lock(result.entryInstance.task.id)
                 result.taskId = result.entryInstance.task.id
+                def taskInstance = Task.lock(result.taskId)
 
                 if(!taskInstance) {
                     status.setRollbackOnly()
-                    result.entryInstance.errors.rejectValue('task', "entry.task.notFound")
+                    result.entryInstance.errors.rejectValue('task', "task.notFound")
                     result.error = true
                     return result
@@ -150 +150 @@
                     if(!taskModification.save()) {
                         status.setRollbackOnly()
-                        taskInstance.errors.rejectValue("task", "entry.task.failedToSaveTaskModification")
+                        taskInstance.errors.rejectValue("task", "task.modifications.failedToSave")
                         result.error = true
                         return result
@@ -160 +160 @@
                     if(!taskInstance.save()) {
                         status.setRollbackOnly()
-                        result.entryInstance.errors.rejectValue("task", "entry.task.failedToSave")
+                        result.entryInstance.errors.rejectValue("task", "task.failedToSave")
                         result.error = true
                         return result