Changeset 203 for trunk/grails-app/controllers

Timestamp:

Nov 30, 2009, 10:28:58 PM (15 years ago)

Author:

gav

Message:

Move task recurring schedule creation to a service.

File:

• trunk/grails-app/controllers/TaskRecurringScheduleDetailedController.groovy (modified) (2 diffs)

trunk/grails-app/controllers/TaskRecurringScheduleDetailedController.groovy

@@ -6 +6 @@
 
     def dateUtilService
+    def taskRecurringScheduleService
 
     def index = { redirect(action:list,params:params) }
@@ -112 +113 @@
 
     def create = {
-        try {
-            def taskInstance = Task.get(params.taskInstance.id)
-            def taskRecurringScheduleInstance = new TaskRecurringSchedule()
-            taskRecurringScheduleInstance.task = taskInstance
-            return [taskRecurringScheduleInstance: taskRecurringScheduleInstance]
+        if(!params.task?.id || !Task.exists(params.task?.id)) {
+            flash.message = "Please select a task, then Create a Recurring Schedule for it."
+            redirect(controller:"taskDetailed", action:"search")
+            return
         }
-        catch(Exception e) {
-            flash.message = "Please select a task, then Create a Recurring Schedule for it"
-            redirect(controller:"taskDetailed", action:"search")
-        }
+        def taskRecurringScheduleInstance = new TaskRecurringSchedule()
+        taskRecurringScheduleInstance.properties = params
+        return [taskRecurringScheduleInstance: taskRecurringScheduleInstance]
     } // end create()
 
     def save = {
-        def taskRecurringScheduleInstance = new TaskRecurringSchedule(params)
-        def taskInstance = Task.get(params.task.id)
+        def result = taskRecurringScheduleService.create(params)
 
-        if(taskInstance.taskRecurringSchedule) {
-            flash.message = "This task already has a recurring schedule"
-            redirect(controller:"taskDetailed", action:"show", id: params.task.id)
+        if(!result.error) {
+            flash.message = "Recurring Schedule ${result.taskRecurringScheduleInstance.id} created."
+            redirect(action:show, id: result.taskRecurringScheduleInstance.id)
         }
         else {
-
-            if(taskRecurringScheduleInstance.nextTargetStartDate < dateUtilService.getToday()) {
-                taskRecurringScheduleInstance.errors.rejectValue("nextTargetStartDate", "taskRecurring.nextTargetStartDate.NotInTheFuture")
-            }
-
-            if(!taskRecurringScheduleInstance.hasErrors() && taskRecurringScheduleInstance.save(flush: true)) {
-
-                taskInstance.taskRecurringSchedule = taskRecurringScheduleInstance
-
-                if(taskInstance.save(flush: true)) {
-                    flash.message = "Recurring Schedule ${taskRecurringScheduleInstance.id} created"
-                    redirect(action:show,id:taskRecurringScheduleInstance.id)
-                }
-                else {
-                    flash.message = "Task could not be saved and therefore the Recurring Schedule has been disgarded, cause unknown."   
-                    render(view:'create',model:[taskRecurringScheduleInstance:taskRecurringScheduleInstance])
-                }
-            }
-            else {
-                render(view:'create',model:[taskRecurringScheduleInstance:taskRecurringScheduleInstance])
-            }
+            render(view:'create',model:[taskRecurringScheduleInstance: result.taskRecurringScheduleInstance])
         }
-
     } // end save()